search

joken-elixir / joken_jwks

A Joken 2 hook for fetching the signer from a public JWKS url
Apache License 2.0
29 stars 24 forks source link

use GenServer instead of Task for the default strategy process #36

Closed lovebes closed 9 months ago

lovebes commented 1 year ago

Polling is a bit more idiomatic when done inside GenServer. Also, having GenServer sets the setting for dynamic spinning up of strategy modules. As-is, it can't, because EtsCache needs to have dynamic table naming too, which needs more customization - at that point it should be done in a seperate, custom strategy (probably involving a Registry too).

Therefore this is still "locked" to spin up pre-defined strategy modules.

In addition, I changed the API calls to be synchronous, as you'd still want to process the outcome of the current API call response before you schedule another API call to prevent any possibility of firing the next API call even when processing the current one didn't finish yet.

victorolinasc commented 1 year ago

This is awesome work @lovebes ! Thanks for your contribution. I should've done this a long time ago.

Just some minor nitpicks with the pipes for opts.

I am interested in having another strategy that spans strategies dynamically. I am also planning on adding more default validations like x5t and so on. If you want to hack on those please do :)

lovebes commented 1 year ago

@victorolinasc I've applied your changes.

Oh awesome! Yes I would very much like to try my hand in creating the strategy that creates other strategies dynamically. I'll write one up pretty soon! It might help when using it for creating an all-encompassing Auth Service that has to reach out to multiple IDPs via OAuth2, but where the reason behind that is due to multitenancy (each tenant has their own JWKS endpoint).

lovebes commented 1 year ago

@victorolinasc I started working on the dynamic supervisor route, and have realized what more to change in DefaultStrategyTemplate to make it work for both "standalone" and in dynamic supervisor mode. I'll add the changes in this PR, or in another PR if that's better.

lovebes commented 1 year ago

Alright I'm done, I actually changed a lot more and made it useable for when it is needed to be run for dynamically starting strategies. https://github.com/joken-elixir/joken_jwks/pull/39 will include and expand this PR.