search

joker-b / oauth

Automatically exported from code.google.com/p/oauth
0 stars 0 forks source link

OAuthRequest::from_request doesn’t get the correct parameters if the HTTP method is DELETE or PUT #38

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
OAuthRequest::from_request should look only look at $_POST for POST requests 
and $_GET for 
everything else.

Original issue reported on code.google.com by chasen%i...@gtempaccount.com on 26 Aug 2008 at 6:37

GoogleCodeExporter commented 9 years ago

Original comment by leah.culver on 14 Jan 2009 at 9:23

GoogleCodeExporter commented 9 years ago 
I believe this is fixed, since $_GET is always part of the parameters, while 
$_POST is only included if HTTP 
method 'POST' and Content-Type is application/x-www-form-urlencoded

I will expand the unit-tests to cover these cases some time later..

Original comment by morten.f...@gmail.com on 30 Jan 2009 at 6:19

GoogleCodeExporter commented 9 years ago 
Yeah, this looks fixed. Thanks for closing it. :)

Original comment by rendezvouscp on 30 Jan 2009 at 9:21

GoogleCodeExporter commented 9 years ago 
No problem..

Original comment by morten.f...@gmail.com on 31 Jan 2009 at 9:06