search

joker1007 / yaml_vault

Yaml file encryption/decryption helper.
MIT License
158 stars 20 forks source link

Using gcp-kms in Ruby 3.1 causes an error. #21

Open kann1020 opened 1 year ago

kann1020 commented 1 year ago

The following error occurred when using gcp-kms with Ruby3.1. （cloudkms_v1/service.rb:867:in `decrypt_crypto_key': wrong number of arguments (given 3, expected 1..2) (ArgumentError)）

google-apis-cloudkms_v1 https://github.com/googleapis/google-api-ruby-client/blob/main/generated/google-apis-cloudkms_v1/lib/google/apis/cloudkms_v1/service.rb#L867 The decrypt_crypto_key argument looks like this.

On the other hand, the yaml_vault is as follows, and the arguments do not match. https://github.com/joker1007/yaml_vault/blob/5adf5b18d7b69f39ec8f6e409040cdcfce1b677c/lib/yaml_vault.rb#L184-L187

I think it will work if I delete, {} , can you fix it?

Incidentally, google-api-client is deprecate, so it would be helpful if you could migrate to google-apis-cloudkms_v1 as well

Thanks.

terasawa2 commented 1 year ago

@joker1007 Do you have any plans to revise?

terasawa2 commented 1 year ago

The following may have the same problem. https://github.com/googleapis/google-api-ruby-client/blob/main/generated/google-apis-cloudkms_v1/lib/google/apis/cloudkms_v1/service.rb#L903