`na_col` argument does not work with both Heatmap() and pheatmap()

jokergoo / ComplexHeatmap

Make Complex Heatmaps

https://jokergoo.github.io/ComplexHeatmap-reference/book/

Other

1.31k stars 228 forks source link

`na_col` argument does not work with both Heatmap() and pheatmap() #1183

Open gurpreet-bioinfo opened 6 months ago

gurpreet-bioinfo commented 6 months ago

Hi @jokergoo , I am using v2.12.1 of the package and na_col argument does not work with both Heatmap() and pheatmap()! :(

almeidasilvaf commented 2 months ago

Same for me. Using {ComplexHeatmap} v2.20.0 and R 4.4.1. The same argument in pheatmap::pheatmap() works, though. It seems like a problem in {ComplexHeatmap}, not in {pheatmap}.

jokergoo commented 2 months ago

Thanks! This is a bug and now I have fixed it. Please install the version from GitHub.

m = matrix(rnorm(100), 10)
m[sample(100, 10)] = NA
Heatmap(m, na_col = "green")

ComplexHeatmap::pheatmap(m, na_col = "green")

almeidasilvaf commented 2 months ago

It works perfectly now. Thanks a lot for fixing this, @jokergoo! I guess you can close this issue now.