search

jokkedk / webgrind

Xdebug Profiling Web Frontend in PHP
Other
3.28k stars 410 forks source link

transparently handle gzip files #153

Closed xabbu42 closed 2 years ago

xabbu42 commented 2 years ago

Fixes #139

Adds dependency on zlib and php with zlib support. I'm not sure if this is acceptable or not.

Also the Nmakefile probably needs to be fixed for windows users. I hope somebody using windows can help with that.

alpha0010 commented 2 years ago

Thanks for your interests in this.

I am unfamiliar with the Windows side (I do not do Windows development). In order to avoid breaking Windows support, could you add preprocessor guards around your changes? Something like $(CXX) -o $(OUT) -O2 -s $(SRCS) -lz -DWITH_ZLIB in the makefile, and #ifdef WITH_ZLIB/#else/#endif in preprocessor.cpp, so compression support can be toggled on/off at build time?

xabbu42 commented 2 years ago

done, so I guess this can be merged now as is. It would still be great if somebody can also test and enable the feature on windows.