search

jokkedk / webgrind

Xdebug Profiling Web Frontend in PHP
Other
3.28k stars 411 forks source link

JavaScript error because of removal of $.browser from jQuery #183

Open vlakoff opened 8 months ago

vlakoff commented 8 months ago

Webgrind 1.9.3

Encountering this JavaScript error:

jquery.blockUI.js:206 Uncaught TypeError: Cannot read properties of undefined (reading 'msie')

Code excerpt:

ie6: $.browser.msie && /MSIE 6.0/.test(navigator.userAgent),

Certainly due to the update to jQuery 1.12.4, as $.browser has been removed in jQuery 1.9.

Note there are also other occurrences of $.browser in the codebase: Search for "$.browser".

vlakoff commented 8 months ago

As a short-term solution, jQuery Migrate could be used, but it would be better to directly update the dependencies:

vlakoff commented 7 months ago

Hi @jokkedk, it seems that you are not active on this project currently. I can understand, there is absolutely no problem with this.

Though, the latest webgrind release can be considered as broken, considering how the jQuery update actually broke things that were working previously.

Thus, as a quick measure to fix things in the short term, maybe you could revert the jQuery update and tag a new webgrind release? Staying on the older -but working- jQuery version would be a lesser evil, for the time being.

giuliopons commented 4 months ago

You can add this line: <script src="https://code.jquery.com/jquery-migrate-1.4.1.js"></script> afterjquery.js in the templates/index.phtml

dandjo commented 4 months ago

@jokkedk would be greate to "hotfix" this issue with my merge request.

AmirL commented 1 month ago

Fix for dockerfile:

# Add jQuery migrate script after the jQuery script in index.phtml
RUN sed -i '/<script src="js\/jquery.js" type="text\/javascript" charset="utf-8"><\/script>/a\
<script src="https://code.jquery.com/jquery-migrate-1.4.1.js"></script>' /var/www/html/templates/index.phtml

or just in bash:

sed -i '/<script src="js\/jquery.js" type="text\/javascript" charset="utf-8"><\/script>/a\
<script src="https://code.jquery.com/jquery-migrate-1.4.1.js"></script>' /var/www/html/templates/index.phtml