jokob-sk / NetAlertX

🖧🔍 WIFI / LAN intruder detector. Scans for devices connected to your network and alerts you if new and unknown devices are found.
GNU General Public License v3.0
3.02k stars 183 forks source link

Mass edit? #571

Closed hobybrenner closed 7 months ago

hobybrenner commented 8 months ago

Is there an existing issue for this?

Is your feature request related to a problem? Please describe

Any chance at getting a mass edit feature? It would be nice to be able to select large groups of devices and mark them as not new, etc.

Describe the solution you'd like

Option to select multiple devices and edit.

Describe alternatives you've considered

Option to select all, or have a select box allowing you to select a group or all devices on the "Devices" page.

Anything else?

I think one of the other forks has this feature.

jokob-sk commented 8 months ago

Hi @hobybrenner ,

Thanks for the suggestion!

Can you elaborate on your use case?

Are you requesting mass-editing all fields or only the New device flag?

Have you considered changing the defaults in the New Devices plugin (Set NEWDEV_dev_NewDevice to false)? If yes and this doesn't solve your issue, could you please elaborate on why?

I'm also considering some rudimentary workflow support, where I'm currently gathering feedback here: https://github.com/jokob-sk/Pi.Alert/issues/562

A current workaround is to use the Device CSV Export > Import approach described here: https://github.com/jokob-sk/Pi.Alert/blob/main/docs/DEVICES_BULK_EDITING.md

I'm trying to understand the exact use case and how to make it useful to as many users :)

Thanks in advance, j

Tharic99 commented 8 months ago

Not OP, but I was just wondering about this about an hour ago. Outside of the "new" flag, one use case I could see for a mass edit would be to set the Icon on multiple devices.

For example, I've got about two dozen Kasa Smart Plugs through the house. They show up on device list as a vendor of "Tp-Link Technologies Co.,Ltd." and a name of "HS103".

A mass edit would be handy to be able to go to Devices, sort by Vendor, select "Mass Edit", put a checkbox in the 19 items from that same Vendor and then update the Icon to all be "plug" (just picked the closest thing that seemed an option on the FA site, but then that also goes back to #550 some too

jokob-sk commented 8 months ago

image

This should be available in the next release. If you can, please have a look at the pi.alert_dev docker image, in about 15 minutes (or after the last action finishes) from now.

It would be great if you could test this on your end by switching to the above image and letting me know if the issue was resolved.

Thanks in advance, j

schmidiij commented 7 months ago

this is still in dev only or?

jokob-sk commented 7 months ago

Hey @schmidiij ,

Yes, I hope for a release in the next few days. Would be great if you could test it if interested. The image name is pi.alert_dev.

Thanks, j

jokob-sk commented 7 months ago

released -> closing