jokob-sk / NetAlertX

🖧🔍 WIFI / LAN intruder detector. Scans for devices connected to your network and alerts you if new and unknown devices are found.
GNU General Public License v3.0
3.05k stars 184 forks source link

Mounting FontAwesome Pro no longer works #594

Closed D3SOX closed 6 months ago

D3SOX commented 7 months ago

Is there an existing issue for this?

Current Behavior

After updating to 24.3.19 this way from the docs to mount FontAwesome Pro results in missing icons when mounting version 6.4.2 in my case. image

Expected Behavior

Work like before

Steps To Reproduce

Try to mount FontAwesome Pro

pialert.conf

I don't think that's relevant

docker-compose.yml

version: "3"
services:
  pialert:
    container_name: pialert
    image: "jokobsk/pi.alert:latest"
    network_mode: "host"
    restart: unless-stopped
    env_file:
      - .env
    volumes:
      - ${APP_DATA_LOCATION}/pialert/config:/home/pi/pialert/config
      - ${APP_DATA_LOCATION}/pialert/db/:/home/pi/pialert/db/
      # FontAwesome Pro
      - /home/nico/pialert/fontawesome-pro-6.4.2-web:/home/pi/pialert/front/lib/AdminLTE/bower_components/font-awesome:ro
    environment:
      - TZ=${TZ}
      - HOST_USER_ID=${HOST_USER_ID}
      - HOST_USER_GID=${HOST_USER_GID}
      - PORT=${PORT}
      - LOG_LEVEL=${LOG_LEVEL}

What branch are you running?

Production

pialert.log

No response

Debug enabled

jokob-sk commented 7 months ago

Hi @D3SOX ,

Thanks for the report.

Can you try to test the dev image once this build finishes: https://github.com/jokob-sk/Pi.Alert/actions/runs/8342660269?

version: "3"
services:
  pialert:
    container_name: pialert
    image: "jokobsk/pi.alert_dev:latest"
    network_mode: "host"
    restart: unless-stopped
    env_file:
      - .env
    volumes:
      - ${APP_DATA_LOCATION}/pialert/config:/home/pi/pialert/config
      - ${APP_DATA_LOCATION}/pialert/db/:/home/pi/pialert/db/
      # FontAwesome Pro
      - /home/nico/pialert/fontawesome-pro-6.4.2-web:/home/pi/pialert/front/lib/AdminLTE/bower_components/font-awesome:ro
    environment:
      - TZ=${TZ}
      - HOST_USER_ID=${HOST_USER_ID}
      - HOST_USER_GID=${HOST_USER_GID}
      - PORT=${PORT}
      - LOG_LEVEL=${LOG_LEVEL}
D3SOX commented 7 months ago

Works fine thanks for the quick fix. Btw also with the new version the site reloads around 20 times when it's open while starting. Is this intended behavior?

jokob-sk commented 7 months ago

Great!

The reloads are intended, although not ideal. I will work on fine-tuning the first load, for now, it's necessary to make sure all resources are loaded after the cache is emptied. This is only done once per session, so I now deem this an acceptable drawback, but definitely plan to improve the experience. Happy for anyone to help out as well.

jimmybrancaccio commented 7 months ago

I can also confirm using the dev image resolves the issue. I believe the problem was that it was trying to access FontAwesome using font-awesome.min.css instead of fontawesome.min.css. Thanks for the fix @jokob-sk ❤️

jokob-sk commented 6 months ago

released 🚀 -> closing