jokob-sk / NetAlertX

πŸ–§πŸ” WIFI / LAN intruder detector. Scans for devices connected to your network and alerts you if new and unknown devices are found.
GNU General Public License v3.0
3.15k stars 186 forks source link

include attributes to device_tracker #703

Closed fama-lama closed 4 months ago

fama-lama commented 5 months ago

Is there an existing issue for this?

Am I willing to test this? πŸ§ͺ

Can I help implement this? πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

Is your feature request related to a problem? Please describe

I have an automation in home assistant to notify if any changes to my network, such as if a new device joins the network etc. In the automation, i would like to include info such as IP, vendor, MAC address at a minimum. currently these are spread between multiple entities.

Screenshot from 2024-06-11 17-09-11

Describe the solution you'd like

copy the same info from these other entities and include them as attributes for the device_tracker "device_tracker.DEVICE_is_present"

Describe alternatives you've considered

it's honestly not necessary. One can build a more complex automation to hunt and parse this info. I think it's just a matter of optimisation to make the entities more user friendly.

Anything else?

i should raise a different bug issue for this but can you remove the underscores for these entity names?

jokob-sk commented 5 months ago

image This should be available in the next release. Please have a look at the netalertx-dev docker image, in about 15 minutes (or after the last action finishes) from now.

πŸ‘‰If I don't get a confirmation that this is working I might pull out the feature to prevent bugs.

Make sure you refresh your browser cache - and click the πŸ”„ refresh button in the top right corner.

It would be great if you could test this (backup everything first or use a new container) on your end by switching to the above image and letting me know if the issue was resolved/the new feature is working.

Thanks in advance, j

jokob-sk commented 5 months ago

i should raise a different bug issue for this but can you remove the underscores for these entity names?

Entity names are used in multiple places (e.g. in the topic) so I won't remove underscores unless really necessary. I don't want to introduce unnecessary complexity into the code if it can be avoided.

jokob-sk commented 5 months ago

Keeping this open for other users to see until released

jokob-sk commented 4 months ago

Releasing -> closing