Map doesn't render correctly in Safari

jokob-sk / NetAlertX

🖧🔍 WIFI / LAN intruder detector. Scans for devices connected to your network and alerts you if new and unknown devices are found.

GNU General Public License v3.0

3.04k stars 183 forks source link

Map doesn't render correctly in Safari #781

Closed LunarJetman0 closed 1 month ago

LunarJetman0 commented 2 months ago

Is there an existing issue for this?

[X] I have searched the existing open and closed issues and I checked the docs https://github.com/jokob-sk/NetAlertX/tree/main/docs

Current Behavior

Map renders lines correctly but blank spaces where the labels should be. Label appears in top right corner but may also be a stack of labels

Expected Behavior

Map renders with labels next ot each connecting line

Steps To Reproduce

OS: MacOS 14.6.1 Safari: Version 17.6 (19618.3.11.11.5)

Configure nodes as per NETWORK.md and click onto the Network map

app.conf

No response

docker-compose.yml

No response

What branch are you running?

Production

app.log

No response

Debug enabled

[X] I have read and followed the steps in the wiki link above and provided the required debug logs and the log section covers the time when the issue occurs.

LunarJetman0 commented 2 months ago

Screenshot shows the issue. I've also tried different user agents. The diagram renders correctly in Brave browser on the same machine.

jokob-sk commented 2 months ago

Hi there,

Regrettably I don't have a Mac system and the bandwidth to support Safari. The primary supported browsers are Firefox and Chrome. Happy for someone to submit a PR with a fix though.

Thanks, J

JackD-01 commented 2 months ago

Have the same problem on my Apple iPad(gen7). The Network does not render correctly, same as image from LunarJetman0. Does not render correctly in Safari but also not in Mozilla Firefox for iPad. I am not a programmer just a happy user of NetAlertX, so I can not help you much.

jokob-sk commented 2 months ago

I regrettably don't have any Apple devices to test this. So if someone can help, that would be great, but I will have to rely on someone from the community.

LunarJetman0 commented 2 months ago

Sorry, also not a developer so unable to help with the code, but happy to test/help any other way I can.

I suspect the issue is with WebKit though as it renders OK on a Mac on other browsers e.g. Brave/Chrome/Firefox, but not on an iPad with any browser (all iOS browsers are WebKit regardless of brand)

jokob-sk commented 1 month ago

Closing for now -> will re-open if someone is able to help

Stationary-1 commented 1 week ago

Which debug information would you need, can’t get the information from the iOS devices, I guess, but the Safari on the MacBook might give away details.

jokob-sk commented 1 week ago

Hi @Stationary-1,

Regrettably I need someone to help me fix this by submitting a PR. Debug information is not sufficient as I can't test a fix. From experience, developing or trying to fix something without being able to test it is almost impossible.

Hope this makes sense.

Stationary-1 commented 1 week ago

Sure that makes sense. If any developer out there at some point in time with access to Safari wants to look at it, I enclose the console output Safari 17.6 marks in red as error on the page. Safari_error_Network.txt