systemik commented 1 month ago

Is there an existing issue for this?

[X] I have searched the existing open and closed issues and I checked the docs https://github.com/jokob-sk/NetAlertX/tree/main/docs

Current Behavior

It seems that devices created by Un-Discoverable plugin are set with a MAC with the same name as the device.

When we then try to assign a device to such dummy device, it fails and the error message states :

[25-Sep-2024 15:15:15 Europe/Berlin] PHP Fatal error: Uncaught Exception: Invalid mac address in /app/front/php/server/devices.php:841

If we manually set a dummy mac address for the dummy device then we can properly assign devices to it.

Expected Behavior

This may be fixed by either creating a dummy mac for the dummy device or by changing the assign code to avoid checking for properly formatted MAC addresses when the device is dummy.

Steps To Reproduce

Create dummy device and try to assign a device to it in the network page.

What branch are you running?

Production

app.log

PHP Fatal error: Uncaught Exception: Invalid mac address in /app/front/php/server/devices.php:841 Stack trace:

0 /app/front/php/server/devices.php(46): updateNetworkLeaf()

1 {main}

thrown in /app/front/php/server/devices.php on line 841

[X] I have read and followed the steps in the wiki link above and provided the required debug logs and the log section covers the time when the issue occurs.

systemik commented 1 month ago

When looking at the code, it seems that a random mac should have been generated with the function "string_to_mac_hash" in the undiscoverable device plugin but it does not work as expected it seems.

Second issue when there is an invalid mac in the list : most devices are reported offline ...

FlyingToto commented 1 month ago

addeddum

Expected Behavior This may be fixed by preferably by allowing linkage to the device pseudo-MAC similar to way NaX allow to link the root firewall to the internet ISP Gateway under MAC=internet. or either by creating a dummy/or updatable mac for the dummy device or by changing the assign code to avoid checking for properly formatted MAC addresses when the device is dummy.

jokob-sk commented 1 month ago

Thanks for the report and help @systemik , @FlyingToto - this should be fixed in the latest release in ~15 min from now -> Closing