jolars / eulerr

Area-Proportional Euler and Venn Diagrams with Ellipses
https://jolars.github.io/eulerr/
GNU General Public License v3.0
130 stars 18 forks source link

Add circles scale to legend #24

Open greboul opened 6 years ago

greboul commented 6 years ago

Hi Jolars, Sorry to ask again another feature but is it possible to add the scale into the legend. As my circles are going from 1 to 1377 and sometimes crossing only for small amount, if I add the quantities it is unreadable. I provided you an example here : screenshot_eulerr_quantities

Or if you can suggest an other way to be able to see as much as possible the information for datasets like mine. Thanks a lot in advance !

jolars commented 6 years ago

Hm, I'm principally opposed to that. The idea is that the sizes are proportional across the panels. You will confused viewers if the areas in the different panels mean different things. Scaling the diagrams wouldn't fix the issues with the left and rightmost diagrams anyway. Do you really need the quantity labels?

Perhaps this could be added as an option in the future but for now I think you could achieve what you want by doing something like

p1 <- plot(fit[[1]])
p2 <- plot(fit[[2]])
gridExtra::grid.arrange(p1, p2)
greboul commented 6 years ago

I think I wasn't clear enough because I agree with you about having proportional sizes across the pannel. The only think I was asking is a scale in the shared legend as this one from ggplot for example : screenshot2_eulerr_quantities

jolars commented 6 years ago

Sorry, now I understand. That's a good idea and I'll see what I can do; but don't expect anything soon.