search

jolars / eulerr

Area-Proportional Euler and Venn Diagrams with Ellipses
https://jolars.github.io/eulerr/
GNU General Public License v3.0
130 stars 18 forks source link

Display a warning when some combinations are not represented in the plot #31

Closed lldelisle closed 6 years ago

lldelisle commented 6 years ago

Hi, Thank you very much for the tool. It is really nice. However, I think it is better to be warned when a combination is not represented. Lucille

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.8%) to 78.666% when pulling 65d2cd802f51f9682698d2835dfd414990453c93 on lldelisle:master into 032e784b9397548e1be181d7894074898c140f7f on jolars:master.

jolars commented 6 years ago

Thank you for your contribution. I disagree, however. Plotting diagrams with some missing combinations is really just a feature of the program and will be unavoidable for large combinations. I don't plan on having warnings thrown every time it happens. I have plans to provide a separate plot for diagnosing the fit.

Also not that you should use warning() and not message() for warnings.

Thanks again.