search

jolars / eulerr

Area-Proportional Euler and Venn Diagrams with Ellipses
https://jolars.github.io/eulerr/
GNU General Public License v3.0
131 stars 18 forks source link

Option to add numbers plot #6

Closed cdeterman closed 7 years ago

cdeterman commented 7 years ago

With the VennDiagram package the user can have numbers directly on the plots which you can see here. Having the option to put the counts (i.e. the original in the eulerr class output) would be useful.

jolars commented 7 years ago

Yup, thanks. It's on my to-do list.

jolars commented 7 years ago

@cdeterman How do you reckon intersections that are present in the input but not in the fit should be visualized? Should they be plotted next to the plot (as a legend)?

cdeterman commented 7 years ago

I would agree that they should be plotted next to the plot. Perhaps a 'warning' message noting that the intersections are present in the input but not the fit?

jolars commented 7 years ago

Okay. I've added an argument that labels unique sections with their respective counts. I do not think adding a warning message is necessary; the output from printing the fit should be sufficient. However, I think it's a good idea to visualize missing values on the side but I'm shelving it for now due to time constraints.

Note that this functionality is currently very slow. I'm not sure how to speed it up without moving it to c++, but I'll look into it later.