jolars / moloch

A LaTeX Beamer theme, forked from the metropolis theme
https://ctan.org/pkg/moloch
Creative Commons Attribution Share Alike 4.0 International
89 stars 5 forks source link

feat: revert changed vertical alignment of title frame #29

Open jpcirrus opened 3 weeks ago

jpcirrus commented 3 weeks ago

8f2a59e replaced \vfill with \vfil in the title page minipage but this lowered the vertical alignment of the minipage contents. This commit reverts the vertical alignment to what it was previously.

jpcirrus commented 3 weeks ago

However, there remains the issue of the contents of the title page being closer to the top of the frame rather than being centered.

jolars commented 3 weeks ago

Thanks for the PR. I'll take a look at this later today.

jolars commented 3 weeks ago

I don't know... I think the new title page looks fine for a title page with an image, but when there is no titlegraphic I think it looks better to have it off-centered towards the bottom. Not sure I can motivate it, it just looks that way to me.

Here is a comparison. Before the PR on the left and after on the right.

tmp

Perhaps the margin to the bottom should be fixed instead. I'm not sure what's best here really.

jpcirrus commented 3 weeks ago

Just seen #31. Should this PR rather be closed in favour of the flexibility of that proposal?

When the title page has a titlegraphic, absolute centering is accomplished with:

\setbeamertemplate{title page}{
  \begin{minipage}{\textwidth}
    \ifx\inserttitlegraphic\@empty\else\usebeamertemplate*{title graphic}\fi
    \ifx\inserttitle\@empty\else\usebeamertemplate*{title}\fi
    \ifx\insertsubtitle\@empty\else\usebeamertemplate*{subtitle}\fi
    \usebeamertemplate*{title separator}
    \expandafter\ifblank\expandafter{\beamer@andstripped}{}{%
      \usebeamertemplate*{author}%
    }
    \ifx\insertinstitute\@empty\else\usebeamertemplate*{institute}\fi
    \ifx\insertdate\@empty\else\usebeamertemplate*{date}\fi
  \end{minipage}%
}

but for reasons I haven't been able to discover, without a titlegraphic that code results in the contents being slightly raised above center.

jolars commented 3 weeks ago

Just seen #31. Should this PR rather be closed in favour of the flexibility of that proposal?

When the title page has a titlegraphic, absolute centering is accomplished with:

\setbeamertemplate{title page}{
  \begin{minipage}{\textwidth}
    \ifx\inserttitlegraphic\@empty\else\usebeamertemplate*{title graphic}\fi
    \ifx\inserttitle\@empty\else\usebeamertemplate*{title}\fi
    \ifx\insertsubtitle\@empty\else\usebeamertemplate*{subtitle}\fi
    \usebeamertemplate*{title separator}
    \expandafter\ifblank\expandafter{\beamer@andstripped}{}{%
      \usebeamertemplate*{author}%
    }
    \ifx\insertinstitute\@empty\else\usebeamertemplate*{institute}\fi
    \ifx\insertdate\@empty\else\usebeamertemplate*{date}\fi
  \end{minipage}%
}

but for reasons I haven't been able to discover, without a titlegraphic that code results in the contents being slightly raised above center.

Yes, maybe so. Although there might be reason to look into the current, default one, as well. Thanks for the example. A simple centered version of the default seems like a good and easy alternative to have.