jolars / moloch

A LaTeX Beamer theme, forked from the metropolis theme
https://ctan.org/pkg/moloch
Creative Commons Attribution Share Alike 4.0 International
91 stars 6 forks source link

`parskip` setting influences spacing in unwanted ways #9

Closed jolars closed 8 months ago

jolars commented 8 months ago

https://github.com/jolars/moloch/blob/726430149bebefb30caff08c3d2d00bb58d721f5/src/beamerinnerthememoloch.dtx#L408-L410

These settings affect spacing in ways which I think are unintended and unwanted. For instance, they insert spacing after list environments, which messes with their vertical alignment, and adds spacing between table captions and tables and verbatim environments and paragraphs.

Removing this would have consequences for a lot of presentations, however, since unless the user has used something like \medskip manually, paragraphs will become clumped together. Perhaps there is a better way to accomplish this.

jolars commented 8 months ago

This is related to https://github.com/josephwright/beamer/issues/512

samcarter commented 8 months ago

Similar to https://github.com/jolars/moloch/discussions/7 I think having a parskip in a presentation isn't as useful as it can be in other classes with longer blocks of text.

I understand your concern that this will mean that many presentation will look differently in moloch than in metropolis, but at least the change will mean that the frame content will be more compact and there won't be any risk of text cut off at the bottom.

jolars commented 8 months ago

I agree that it's not as useful, no, but I would personally have liked to see paragraph spacing in beamer.

But irrespective of that, the parskip change in the package is currently not working optimally and resulting in these rather strange spacing problems. Also, it has no effect inside for instance the block environment, which just makes the setting clunky and the results hard to predict (at least for new users).

So I think I'll remove the parskip setting. Thanks for the input again!

Enivex commented 4 weeks ago

Similar to #7 I think having a parskip in a presentation isn't as useful as it can be in other classes with longer blocks of text.

I understand your concern that this will mean that many presentation will look differently in moloch than in metropolis, but at least the change will mean that the frame content will be more compact and there won't be any risk of text cut off at the bottom.

I strongly disagree with this.

I currently have to manually insert skips because moloch is too compact.

If you're at risk of getting text cut off, then you're putting too much text into your slides.

jolars commented 4 weeks ago

Yes, but at least the change doesn't break someone's existing presentation so badly that some content would be lost (get cut off).

Personally I think it's fine that you have to manually insert skips. This aligns with how beamer works by default and how most other themes work too. If there was some way to produce a good implementation of parskip for moloch, then I would not be opposed to having it be an opt-in.