search

jolars / slopecd

4 stars 2 forks source link

Collect timings from inside solvers #17

Closed jolars closed 2 years ago

jolars commented 2 years ago

Add some lines to collect timings from inside solvers. I considered making this optional but I don't really think the overhead is large enough to care about, or what do you think?

Here's the current state of affairs (pgd is actually fista). And yes, you don't need to tell me about how "well" the proxsplit strategy performs =,)

image

Klopfe commented 2 years ago

the proxsplit method can be improved and it's really good to look into it so no worries. It's really great to have access to the time like this, it was missing. Thanks a lot!

mathurinm commented 2 years ago

I rename the variable times to avoid clash with the time module, and also because it stores more than one times (the same way we he gaps) Since we return one more variable now, I deleted theta from the returned variables of prox_grad

LGTM !

jolars commented 2 years ago

Great, thanks @mathurinm !

jolars commented 2 years ago

And thanks @Klopfe too! (Sorry I missed your reply at first)