search

joleys / niko-home-control-II

Home Assistant Custom Integration for Niko Home Control II
MIT License
74 stars 21 forks source link

Switch from deprecated TIME_MINUTES to UnitOfTime.MINUTES #111

Closed xirixiz closed 8 months ago

xirixiz commented 8 months ago

I've noticed the following warning in HASS:

2024-01-15 22:14:02.684 WARNING (MainThread) [homeassistant.const] TIME_MINUTES was used from nhc2, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTime.MINUTES instead, please create a bug report at https://github.com/joleys/niko-home-control-II/issues                                                                                                                                                                                                                                                                                  2024-01-15 22:14:02.696 WARNING (MainThread) [homeassistant.const] TIME_MINUTES was used from nhc2, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTime.MINUTES instead, please create a bug report at https://github.com/joleys/niko-home-control-II/issues                                                                                                                                                                                                                                                                                  2024-01-15 22:14:02.705 WARNING (MainThread) [homeassistant.const] TIME_MINUTES was used from nhc2, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTime.MINUTES instead, please create a bug report at https://github.com/joleys/niko-home-control-II/issues

Changes made to switch from the "in the near future" deprecated TIME_MINUTES to UnitOfTime.MINUTES. In order to help out on this nice component, I hope this PR brings a nice contribution.

tijsverkoyen commented 8 months ago

@xirixiz Thx! I am working on bringing the Integration up to date with v1.3 of the documentation in https://github.com/joleys/niko-home-control-II/pull/110 Which also includes this fix: https://github.com/joleys/niko-home-control-II/pull/110/commits/87b74343d421bc6cc3f5375e05eabd8929557dd4

xirixiz commented 8 months ago

Thanks! Happy to help.

I also maintain a component myself. If you ever need help, just send me a message. Always willing to do some contribution as I know it can be challanging sometimes in maintaining these things together with a personal life 😄

xirixiz commented 8 months ago

... ah, I can check it here to help out I see: https://github.com/joleys/niko-home-control-II/pull/110

Great!