search

jolicode / automapper

:rocket: Very FAST :rocket: PHP AutoMapper with on the fly code generation
https://automapper.jolicode.com/
MIT License
154 stars 15 forks source link

Add support for phpstan/phpdoc-parser 2 #205

Closed MrMeshok closed 1 day ago

MrMeshok commented 3 days ago

I noticed locally that random test started to fail, turns out it's because phpdocumentor/type-resolver added support for phpstan/phpdoc-parser v2, but this library not ready for phpdoc-parser v2. I chose minimal version of 1.13 because minimal version of phpdocumentor/type-resolver required it so there should be no changes to composer update --prefer-lowest

Korbeil commented 3 days ago

Is it not possible to have something compatible like Symfony did with TypeInfo with https://github.com/symfony/symfony/pull/58804 ?

MrMeshok commented 3 days ago

Is it not possible to have something compatible like Symfony did with TypeInfo with symfony/symfony#58804 ?

It's definitely possible, I just did quick fix, this issue probably gonna show up then someone does composer update in their project. Also phpstan/phpdoc-parser should stay in composer.json so this doesn't happen again

MrMeshok commented 1 day ago

@Korbeil I changed PR to add support to v2 instead of locking to v1