jolicode / castor

🦫 DX oriented task runner and command launcher built with PHP.
https://castor.jolicode.com
MIT License
395 stars 20 forks source link

add --since 0 to wait_for_docker_container_task example #498

Closed YannCharlou-CleverAge closed 1 month ago

YannCharlou-CleverAge commented 1 month ago

to avoid checking the logs from a previous container start

lyrixx commented 1 month ago

Thanks

pyrech commented 1 month ago

@YannCharlou-CleverAge Are you sure this argument works as expected?

I just tested on a docker logs command in one of my project, but it did not change anything. And according to the documentation, I would expect passing 0 as the value of since parameter would mean "logs since 1970-01-01" but I fail to see how this would filter logs of a previous container start

YannCharlou-CleverAge commented 1 month ago

@YannCharlou-CleverAge Are you sure this argument works as expected?

I just tested on a docker logs command in one of my project, but it did not change anything. And according to the documentation, I would expect passing 0 as the value of since parameter would mean "logs since 1970-01-01" but I fail to see how this would filter logs of a previous container start

Hi @pyrech , Oh I apoplgize you are totally right. After checking docker documentation I don't understand why it was working properly on my side.

Since this PR is closed, I pushed another one to properly use the --since option : https://github.com/jolicode/castor/pull/500