jolicode / docker-starter

🏗️ A skeleton to start a new web project with PHP, Docker and Castor
MIT License
337 stars 34 forks source link

PHPStan level 8 compliance #324

Open JorickPepin opened 1 month ago

JorickPepin commented 1 month ago

To fix:

------ ---------------------------------------------------------------------- 
  Line   .castor/docker.php                                                    
 ------ ---------------------------------------------------------------------- 
  362    Parameter #1 $data of class Castor\Context constructor expects        
         array{project_name: string, root_domain: string, extra_domains:       
         array<string>, project_directory: string, php_version: string,        
         docker_compose_files: array<string>, macos: bool, power_shell: bool,  
         ...}, non-empty-array<string, mixed> given.                           
 ------ ---------------------------------------------------------------------- 

This may not be the cleanest way to do it, WDYT?

lyrixx commented 1 month ago

This fix seems weird to me. Is there a better way to fix it? IIRC, there one but can't remember 🙃