search

jolicode / elastically

🔍 JoliCode's Elastica wrapper to bootstrap Elasticsearch PHP integrations
248 stars 37 forks source link

Indexer::scheduleIndex(), scheduleUpdate(), scheduleCreate() - DRY principle #117

Closed insekticid closed 1 year ago

insekticid commented 1 year ago

https://github.com/jolicode/elastically/blob/a116efb71eb81576bf21efab32ea6d0bbaf9b57d/src/Indexer.php#L42

These three methods Indexer::scheduleIndex(), scheduleUpdate(), scheduleCreate() have the same code , respect DRY principe and refactor this code

image

lyrixx commented 1 year ago

Hello,

Thanks for your feedback.

We are fine with the current code. But If you want to contribute, feel free to open a PR.

In the meantime, I'll close this issue because it does not bring anything useful.