search

jolicode / elastically

🔍 JoliCode's Elastica wrapper to bootstrap Elasticsearch PHP integrations
MIT License
248 stars 37 forks source link

Add missing @throws annotation #171

Closed VincentLanglet closed 1 year ago

VincentLanglet commented 1 year ago

Cf https://github.com/jolicode/elastically/pull/160#issuecomment-1593688166

VincentLanglet commented 1 year ago

@damienalexandre @lyrixx

I added all the @throws annotation and configured PHPStan for it.

The 4 tests failing are about unrelated deprecations since SF 6.3 is released.

VincentLanglet commented 1 year ago

You're welcome. If you have time for a release, this would be perfect :)

damienalexandre commented 1 year ago

We need to fix the tests and update the changelog before releasing 😬 If someone has time today? (I don't 🙈)

VincentLanglet commented 1 year ago

Since the deprecation is coming from generated code, this issue need to be solve https://github.com/janephp/janephp/issues/727

Simpler solution may be to change the <server name="SYMFONY_DEPRECATIONS_HELPER" value="max[direct]=0"/> config

lyrixx commented 1 year ago

Good to me 👍🏼 Would you mind to subit a PR?

VincentLanglet commented 1 year ago

Sure https://github.com/jolicode/elastically/pull/172

damienalexandre commented 1 year ago

v1.8.4 is released!