jolicode / elastically

🔍 JoliCode's Elastica wrapper to bootstrap Elasticsearch PHP integrations
MIT License
248 stars 39 forks source link

Improvement: add DataCollector for elastically #38

Open gabiudrescu opened 4 years ago

gabiudrescu commented 4 years ago

I am noting down feedback as I have started playing around with https://github.com/monsieurbiz/SyliusSearchPlugin

I might be able to contribute, if I end up implementing this in my project, but first, I want to hear your opinion as well.


I would like to have a DataCollector for elastically, similar with what FOS Elastica has.

damienalexandre commented 4 years ago

Hi,

yes that's something I'd like to have as well.

But it has to add value somehow. For example, just listing the request/responses does not add anything, because when you use the HttpClient for Symfony, you already got the Http Calls panels with all the informations.

gabiudrescu commented 4 years ago

Hmm, indeed. I opened this after I have tested this https://github.com/monsieurbiz/SyliusSearchPlugin

And I think for some reason, they don't use Symfony Http client.

What would you want to see in a data collector?

damienalexandre commented 4 years ago

Here is what I can think of:

That's just what pop's up my head right now but not all of those are worth the time :+1:

tacman commented 3 years ago

I would also like to see this, but I'm wondering if this should be part of an ElasticallyBundle, rather than part of the core library.

I think a bundle would also allow some other goodies that FOSElasticaBundle has, like a command line way to populate the database.