jolicode / elastically

🔍 JoliCode's Elastica wrapper to bootstrap Elasticsearch PHP integrations
248 stars 37 forks source link

purgeOldIndices raise exception if closing indices isn't allowed on the cluster. #49

Open ThibautSF opened 3 years ago

ThibautSF commented 3 years ago

The Close API doc says :

Closed indices consume a significant amount of disk-space which can cause problems in managed environments. Closing indices can be disabled via the cluster settings API by setting cluster.indices.close.enable to false. The default is true.

Some clusters may have the default value of cluster.indices.close.enable set to false. Which can produce this kind of exception : Uncaught Elastica\\Exception\\ResponseException: closing indices is disabled - set [cluster.indices.close.enable: true] to enable it. NOTE: closed indices still consume a significant amount of diskspace

Some ideas:

Besides, the Cluster Update Settings API doc gives the following order of precedence:

  1. transient cluster settings
  2. persistent cluster settings
  3. settings in the elasticsearch.yml configuration file.

Then my actual code to do this force mode on my side

$mycluster = new Cluster($client);
$mysettings = $mycluster->getSettings();

$oldParam = $mysettings->getTransient('cluster.indices.close.enable');

if (true !== $oldParam) {
    $mysettings->setTransient('cluster.indices.close.enable', true);
}
$indexBuilder->purgeOldIndices($indexname);
if (true !== $oldParam) {
    $mysettings->setTransient('cluster.indices.close.enable', $oldParam);
}