search

jolicode / elastically

🔍 JoliCode's Elastica wrapper to bootstrap Elasticsearch PHP integrations
248 stars 37 forks source link

PHP 8 #58

Closed insekticid closed 3 years ago

insekticid commented 3 years ago

Your requirements could not be resolved to an installable set of packages. php_1 | php_1 | Problem 1 php_1 | - jolicode/elastically[v1.1.0, ..., v1.1.1] require php ^7.2 -> your php version (8.0.2) does not satisfy that requirement. php_1 | - Root composer.json requires jolicode/elastically ^1.1 -> satisfiable by jolicode/elastically[v1.1.0, v1.1.1].

Korbeil commented 3 years ago

This won't be enought, you also need to update ruflin/elastica library since current version does not support PHP 8. But there is no version with PHP 8 support at the moment, we have to wait https://github.com/ruflin/Elastica/pull/1871 first.

And please add PHP 8 CI run in order to validate that everything works as expected :wink:

jmsche commented 3 years ago

FYI elastica 7.1.0 was released this morning with PHP 8.0 support.

damienalexandre commented 3 years ago

Thanks a lot @insekticid - I just merged https://github.com/jolicode/elastically/pull/59 which resolves the same issue but in a more complete way (with the tests also running on PHP 8).