jolicode / elastically

🔍 JoliCode's Elastica wrapper to bootstrap Elasticsearch PHP integrations
248 stars 37 forks source link

v1.4 error after update #92

Closed robin69 closed 2 years ago

robin69 commented 2 years ago

Hy, Thx for your great work. Sorry if I miss something in my description. This is the first time I wrote an issue.

I just updated with composer update and get the v1.4. At the end of the composer update process I have this message :

`Loading composer repositories with package information Restricting packages listed in "symfony/symfony" to "5.3.*" Updating dependencies Lock file operations: 0 installs, 4 updates, 0 removals

What about running composer global require symfony/thanks && composer thanks now? This will spread some love by sending a star to the GitHub repositories of your fellow package maintainers.

Run composer recipes at any time to see the status of your Symfony recipes.

Executing script cache:clear [KO] [KO] Script cache:clear returned with error code 1 !! !! In DefinitionErrorExceptionPass.php line 54: !!
!! Cannot autowire service "JoliCode\Elastically\Messenger\IndexationRequestHandler": argument "$indexer" of method "__construct()" references class "JoliCode\Elastically\Indexer" but no such service exists.
!!
!! !! Script @auto-scripts was called via post-update-cmd PS C:\wamp64\www\symfony_projects\uniform3> php .\bin\console cache:clear

In DefinitionErrorExceptionPass.php line 54:

Cannot autowire service "JoliCode\Elastically\Messenger\IndexationRequestHandler": argument "$indexer" of method "__construct()" references class "JoliCode\Elastically\Indexer" but no such service exists.
`

damienalexandre commented 2 years ago

Hi, sorry to hear about your issue.

Can you verify that all the services are defined as documented?

https://github.com/jolicode/elastically#client-as-a-service

Thanks!

robin69 commented 2 years ago

oups, actually it wasn't !

thx for your answer :)

klapaudius commented 2 years ago

Hello it would have been great to have deprecation warnings instead of a 500 on the whole project or since 1.3 configuration make the 1.4 crash maybe 1.4 could be a 2.0

damienalexandre commented 2 years ago

Hi :wave:

We introduced a lot of backward compatibility layer in #78 but it was not enough, sorry about that.