search

jolicode / elastically

🔍 JoliCode's Elastica wrapper to bootstrap Elasticsearch PHP integrations
248 stars 37 forks source link

Symfony 6 #93

Closed jmsche closed 2 years ago

jmsche commented 2 years ago

Hi,

This little PR to allow Symfony 6 :)

I adapted the CI script so it would run on all supported major versions of Symfony.

lyrixx commented 2 years ago

Thanks a lot for this PR.

Unfortunately, it looks like some upstream vendor should be updated first.

jmsche commented 2 years ago

Hi Grégoire,

Yes I noticed the same.

I opened an issue on the vendor, I'll see if I can do some PRs there as well but I'm not sure I'll be able to achieve this as it seems to require a lot of work, on a vendor I don't know well :)

Korbeil commented 2 years ago

Hey, I updated Jane, could you reload the tests / push a build ?

Korbeil commented 2 years ago

You have to use Jane ^7 to have the Symfony 6 compatible stuff. This should be an easy migration, if you want I can do it in another PR to avoid conflicting with your changes.

jmsche commented 2 years ago

Yes, if you can do that in an other PR it would be awesome :)

jmsche commented 2 years ago

Always happy to help :)