search

jolicode / slack-php-api

:hash: PHP Slack Client based on the official OpenAPI specification
https://jolicode.github.io/slack-php-api/
MIT License
221 stars 54 forks source link

Fixes remaining "ts" parameters from number to string type #105

Closed jeremeamia closed 3 years ago

jeremeamia commented 3 years ago

Fixes remaining "ts" parameters from number type to string type. Similar issues reported for other parameters in #12, #22, #26, #27, and #75. Also adds the phpunit result cache file to gitignore list.

jeremeamia commented 3 years ago

@damienalexandre It's unclear how to get the tests to run correctly. I appreciate any help with that and for considering this change. Thanks.

damienalexandre commented 3 years ago

Hi, thanks for your PR! Looks like there is an issue with our TravisCI configuration, I will have a look.

damienalexandre commented 3 years ago

The tests are RED here because they are not run correctly on forks (secret variables are not exposed to avoid leak). Sorry about that.

Also your PR is incomplete, can you push the new generated code too? You have to follow those steps:

https://github.com/jolicode/slack-php-api/blob/master/doc/updating-sdk.md#regenerate-the-sdk

Thanks!

jeremeamia commented 3 years ago

Added the newly generated bits.

damienalexandre commented 3 years ago

Thanks @jeremeamia! I'm going to add some tests and publish a release today.

jeremeamia commented 3 years ago

Thanks @damienalexandre! This made it like 20 times easier to get a single message by its ts.