Update: Change HTTP method of views API and parameters requirement

jolicode / slack-php-api

:hash: PHP Slack Client based on the official OpenAPI specification

https://jolicode.github.io/slack-php-api/

MIT License

221 stars 54 forks source link

Update: Change HTTP method of views API and parameters requirement #130

Closed dqhuy78 closed 2 years ago

dqhuy78 commented 2 years ago

Hi @pyrech, I have closed my previous pull request and added this one following your instruction in updating the SDK, please check it. Thank you.

mpyw commented 2 years ago

I think the fix is very important. Are there any plans to merge?

pyrech commented 2 years ago

Hi @dqhuy78 and @mpyw Sorry for this delay, I forgot to review this PR sooner :disappointed: Looks like there is some conflicts with some PR merged lately. Could you rebase it? We will merge it soon after that. Thanks

damienalexandre commented 2 years ago

Fixed by https://github.com/jolicode/slack-php-api/pull/146 ; thanks for your time!