Closed mpyw closed 2 years ago
@damienalexandre Hi, there are some problems:
./bin/slack-api-client-generator spec:update
partially fails and it generates *.rej
file.vendor/bin/jane-openapi generate --config-file=.jane-openapi.php
gives no effect on SDK about team_id
.vendor/bin/jane-openapi generate --config-file=.jane-openapi.php
gives effect which makes some token
parameter required.They look wrong, what should I do next?
Hey!
I think something went wrong, I tried it locally and it was fine, here is what I did:
# get your first commit
git cherry-pick 5f17c6f
# remove existing SDK
rm -Rf generated/*
# build new SDK with team ID
vendor/bin/jane-openapi generate --config-file=.jane-openapi.php
# run the tests and check the code (team id is here!)
vendor/bin/simple-phpunit
# update the patch file automatically
./bin/slack-api-client-generator spec:generate-patch
# check the patch is valid
./bin/slack-api-client-generator spec:update
That's it - you can then just commit the result.
@damienalexandre Thanks for the heads up! It is ready for review now
Looks good now! Thanks a lot for this contribution, that helps a lot :yum: