jolicode / slack-php-api

:hash: PHP Slack Client based on the official OpenAPI specification
https://jolicode.github.io/slack-php-api/
MIT License
223 stars 56 forks source link

Add team_id support for 3 endpoints #140

Closed mpyw closed 2 years ago

mpyw commented 2 years ago
mpyw commented 2 years ago

@damienalexandre Hi, there are some problems:

They look wrong, what should I do next?

damienalexandre commented 2 years ago

Hey!

I think something went wrong, I tried it locally and it was fine, here is what I did:

# get your first commit
git cherry-pick 5f17c6f
# remove existing SDK
rm -Rf generated/*
# build new SDK with team ID
vendor/bin/jane-openapi generate --config-file=.jane-openapi.php
# run the tests and check the code (team id is here!)
vendor/bin/simple-phpunit
# update the patch file automatically
./bin/slack-api-client-generator spec:generate-patch
# check the patch is valid
./bin/slack-api-client-generator spec:update

That's it - you can then just commit the result.

mpyw commented 2 years ago

@damienalexandre Thanks for the heads up! It is ready for review now

damienalexandre commented 2 years ago

Looks good now! Thanks a lot for this contribution, that helps a lot :yum: