jolicode / slack-php-api

:hash: PHP Slack Client based on the official OpenAPI specification
https://jolicode.github.io/slack-php-api/
MIT License
221 stars 54 forks source link

Update views.* endpoints to use POST method instead of GET #146

Closed matthewnessworthy closed 2 years ago

matthewnessworthy commented 2 years ago

Fixes #111 Replaces #130 (because of merge conflicts)

First updated the SDK with the latest updates

rm -Rf generated/*
vendor/bin/jane-openapi generate --config-file=.jane-openapi.php
./bin/slack-api-client-generator spec:generate-patch
./bin/slack-api-client-generator spec:update

Then after updating the relevant HTTP methods in resources/slack-openapi-patched.json

./bin/slack-api-client-generator spec:generate-patch
./bin/slack-api-client-generator spec:update
vendor/bin/jane-openapi generate --config-file=.jane-openapi.php
matthewnessworthy commented 2 years ago

@damienalexandre please review

damienalexandre commented 2 years ago

147 has been merged, you have to rebuild this PR from "main". Sorry about that :yum:

matthewnessworthy commented 2 years ago

@damienalexandre no worries, all done

damienalexandre commented 2 years ago

Thanks a lot!

matthewnessworthy commented 2 years ago

Glad i could help, thanks for the support and hand-holding!