Closed damienalexandre closed 4 years ago
Looks like Slack changed some object definition and used items
to describe possible variant for some object. In particular, the objs_user
changed to differentiate normal users and enterprise users and is now rendered as two classes ObjsUserItem0
and ObjsUserItem1
instead of the previous ObjsUser
. The denormilizer even returns stdClass
instead of these classes.
We should probably apply a patch to transform back the user model in one class. Should we also fix other models that are now described with the items
notation?
You were right, the Slack specification introduced some polymorphic objects that cannot be handled gracefully in the generated client.
I added two patches to merge those objects.
Could you please test again?
@damienalexandre does this fix #7 ?
As far as I can guess, yes... maybe? But it should be ok on master too... did you try again recently?
Look at this part:
If the status is not 200, the UsersListGetResponsedefault
object is used, and the error string is here:
The PR now works great on https://github.com/jolicode/secret-santa. Great jobs :clap: