search

jolicode / slack-php-api

:hash: PHP Slack Client based on the official OpenAPI specification
https://jolicode.github.io/slack-php-api/
MIT License
221 stars 54 forks source link

Better spec completeness #78

Closed pyrech closed 4 years ago

pyrech commented 4 years ago

Even if Slack's spec miss definitions, it provides a lot of example responses that can quite often be used to guess what schema parts are missing.

So I wrote a small script (bin/checker.php) that prints a useful summary of what looks missing/invalid according to the examples:

image

Thanks to that output, I could fix a lot of things as you can see in the provided patch :slightly_smiling_face:

lsnider commented 4 years ago

fwiw, this PR had it in a missing piece which we needed and this branch worked as expected in my branch. 👍