search

jolie / website

The Jolie website
8 stars 8 forks source link

Add Download.html and Download.md #27

Closed WuoTizio closed 4 years ago

WuoTizio commented 5 years ago

modified line 41 and 78 foraward

thesave commented 5 years ago

Thanks for your contribution and sorry for the delayed response. It seems like there is something wrong with the indentation as git cannot properly mark the changes, i.e., it looks like the whole file changed, while it should be the case. Please, can you revise your pull-request and make sure it correctly marks only the relevant changes between the old and new version? Also, I would suggest modifying the download.md which we can then use to generate the html version.

WuoTizio commented 5 years ago

Good morning Thesave, I apologize, too, if I answer only now very late, because I was away from home for 2 weeks. Sorry I didn't think that in English the "Enter" key, say "Enter key", I thought you could only say "Enter". Tuesday I go home and immediately check the file download.html and I will edit the file download.md. I apologize if the "Pull Request" was not successful or if I did something wrong, it is the first time I use git, I will check immediately Tuesday. I apologize again for the late reply.

Da: thesave notifications@github.com Inviato: domenica 1 settembre 2019 22:57 A: jolie/website website@noreply.github.com Cc: WuoTizio alexanothertime@live.it; Author author@noreply.github.com Oggetto: Re: [jolie/website] Add files via upload (#27)

Thanks for your contribution and sorry for the delayed response. It seems like there is something wrong with the indentation as git cannot properly mark the changes, i.e., it looks like the whole file changed, while it should be the case. Please, can you revise your pull-request and make sure it correctly marks only the relevant changes between the old and new version? Also, I would suggest modifying the download.md which we can then use to generate the html version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jolie/website/pull/27?email_source=notifications&email_token=AMQKRAYETK2GJNXGDYLTRCTQHSTM5A5CNFSM4IHKZIY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5UZD7I#issuecomment-527012349, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMQKRA464WUR32DMOABGFU3QHSTM5ANCNFSM4IHKZIYQ.

WuoTizio commented 5 years ago

I continue to give error when I try to do the "Pull Request". I get this as a message: "This branch has conflicts that must be resolved Only those with write access to this repository can merge pull requests. " Could this be the problem? If not I can send the files download.html and download.md modified by email.

fmontesi commented 4 years ago

@thesave what should we do here?

thesave commented 4 years ago

From the diff I cannot see what was the intended modification and it has been too long for me to remember. It is a problem also that the PR does not contain the requested modification on the downloads.md file as requested 😕