search

joliss / broccoli-sass

Sass compiler for Broccoli, using libsass
MIT License
44 stars 97 forks source link

Added support for the node-sass includePaths option #14

Closed simonexmachina closed 10 years ago

simonexmachina commented 10 years ago

Any issues with this PR? It'd be good to get this merged in.

joliss commented 10 years ago

Hm, I believe this basically duplicates the functionality of the first array argument (inputTrees). You can just pass in strings there.

I'd also generally like to avoid letting people bypass the Broccoli tree system - that is, if a plugin reads stuff from the file system, it should always go through a tree, even if it's just a plain string (since it will be auto-watched).

simonexmachina commented 10 years ago

Okay, that's a good point - I did think of that but needed this to work with ember-cli where I don't have control over the input trees from the Brocfile (they're provided from inside ember-cli).

However we now have rudimentary addon support in ember-cli, and I'm going to be publishing ember-cli-sass to add sourceMap support anyway, so I can investigate adding includePaths support there.

There's perhaps an argument that the includePaths option is useful in this module for that exact use case, but you're right that it's duplication. I'll let you choose whether to close this issue - I'm happy either way.

joliss commented 10 years ago

[For posterity from our conversation: Seems like this is probably something that should be addressed in ember-cli.]

I'll go ahead and close this.

simonexmachina commented 10 years ago

Great, thanks.