search

joliss / broccoli-sass

Sass compiler for Broccoli, using libsass
MIT License
44 stars 97 forks source link

Use path.join to fix regression bug re. missing leading slashes #31

Closed sebastianseilund closed 10 years ago

sebastianseilund commented 10 years ago

https://github.com/joliss/broccoli-sass/pull/28 introduced a regression bug that made output paths without leading slashes not work. No leading slash is the documented behavior in the README.

https://github.com/joliss/broccoli-sass/commit/10df2aa70871065ac0d6b0d500b7457ae9b53cf4#diff-168726dbe96b3ce427e7fedce31bb0bcL34 was changed to https://github.com/joliss/broccoli-sass/commit/10df2aa70871065ac0d6b0d500b7457ae9b53cf4#diff-168726dbe96b3ce427e7fedce31bb0bcR35

I fixed it using path.join, which I think should always be used, except when called repeatedly for performance optimization.

I recommend releasing a new version asap as this will break the build for everyone who are not using leading slashes.

simonexmachina commented 10 years ago

Thanks @sebastianseilund, I'll push a new version now.

simonexmachina commented 10 years ago

@joliss, I've pushed this to master but I don't have permission to publish the npm package. Would you please add me using npm owner add aexmachina broccoli-sass?

joliss commented 10 years ago

Releasesd in 0.2.4 :-) Thanks!