search

joliss / broccoli-sass

Sass compiler for Broccoli, using libsass
MIT License
44 stars 97 forks source link

updated node-sass to 1.1.2 #41

Closed toranb closed 9 years ago

toranb commented 9 years ago

node-sass 1.1.4 has known issues on centOS and RedHat linux machines - updating to 1.1.3 solved this for me.

More on the error here:

https://www.centos.org/forums/viewtopic.php?t=5807

toranb commented 9 years ago

If this is pulled in -could we also bump the version to 0.3.4 so I can get a PR out to ember-cli-sass ?

simonexmachina commented 9 years ago

I'd prefer node-sass to fix the issue than for us to pin the dependency to an old version. Do we have any idea when the issue will be fixed in node-sass?

toranb commented 9 years ago

Fair point - I'll need to use 2 forks until that issue is fixed (the reason I was feeling so much pain and tried to push this PR up).

thanks for the feedback!

simonexmachina commented 9 years ago

Thanks @toranb, if you feel like posting your forks into this thread then others why may be experiencing this issue can use them. Is there an open issue on node-sass where I can track the progress of this issue?

toranb commented 9 years ago

Sounds like a plan! I'll report back when I can reproduce it in a virtualbox image for centOS / REHL 7

Here is the issue I'm following on node-sass

https://github.com/sass/node-sass/issues/517

simonexmachina commented 9 years ago

That node-sass issue is closed - should it be reopened?

toranb commented 9 years ago

14 days ago this came up on that thread (my exact OS btw)

Definitely still a problem on CentOS 6.6 and thus RHEL.
toranb commented 9 years ago

Here are the 2 forks

https://github.com/toranb/ember-cli-sass https://github.com/toranb/broccoli-sass

To get this in your project today -> update the package.json file to reflect my master branch until CentOS 6.5 is fixed / node-sass supports CentOS 6.5

"ember-cli-sass": "git+https://github.com/toranb/ember-cli-sass"

note: I found node-sass@1.1.2 was the only version of node-sass that would work on CentOS 6.5 with gcc < 4.8

simonexmachina commented 9 years ago

Great, thanks - that issue's been reopened now. I'll keep track as well.