search

joliss / broccoli-sass

Sass compiler for Broccoli, using libsass
MIT License
44 stars 97 forks source link

Update node sass to 2.0.1 #45

Closed deepflame closed 9 years ago

deepflame commented 9 years ago

needed to update node sass to 2.0.1 to make it compile on Node 0.12 .

deepflame commented 9 years ago

Hmm, weird. I get the following error now:

16:47:46 ember.1 | `libsass` bindings not found. Try reinstalling `node-sass`?
16:47:46 ember.1 | Error: `libsass` bindings not found. Try reinstalling `node-sass`?
16:47:46 ember.1 |     at getBinding (/Users/aboehrnsen/Developer/frontrunnerio/clients/node/APP/northapp-staging/frontend/node_modules/broccoli-sass/node_modules/node-sass/lib/index.js:22:11)
16:47:46 ember.1 |     at Object.<anonymous> (/Users/aboehrnsen/Developer/frontrunnerio/clients/node/APP/northapp-staging/frontend/node_modules/broccoli-sass/node_modules/node-sass/lib/index.js:188:23)
16:47:46 ember.1 |     at Module._compile (module.js:460:26)
16:47:46 ember.1 |     at Object.Module._extensions..js (module.js:478:10)
16:47:46 ember.1 |     at Module.load (module.js:355:32)
16:47:46 ember.1 |     at Function.Module._load (module.js:310:12)
16:47:46 ember.1 |     at Module.require (module.js:365:17)
16:47:46 ember.1 |     at require (module.js:384:17)
16:47:46 ember.1 |     at Object.<anonymous> (/Users/aboehrnsen/Developer/frontrunnerio/clients/node/APP/northapp-staging/frontend/node_modules/broccoli-sass/index.js:5:12)
16:47:46 ember.1 |     at Module._compile (module.js:460:26)

Also reinstalling does not help.

Please use this with care. It needs more testing.

simonexmachina commented 9 years ago

This PR should be closed in favour of #43 because there's changes to the node-sass API, and that PR also provides support for sourcesContent, which is pretty important in the case of broccoli (source maps are unviable without it).

Regarding the problem with install, I've hit the same issue with #43. I've got a release deadline today, would you mind following up that install issue with node-sass?

deepflame commented 9 years ago

I saw that you also upgraded to 2.0.1 now. Great, then I will close my pull request and hope that yours will be merged soon.

I opened an issue on node-sass. Feel free to add to this: https://github.com/sass/node-sass/issues/678