search

joliss / broccoli-sass

Sass compiler for Broccoli, using libsass
MIT License
44 stars 97 forks source link

Upgraded to node-sass 2.0.1 #49

Closed hipertracker closed 9 years ago

hipertracker commented 9 years ago

Upgrade node-sass to 2.0.1. (Older node-sass version is not working on OS X)

lessless commented 9 years ago

+1 for that, cause 1.2.3 failing with node 0.12 https://github.com/sass/node-sass/issues/550

Asgaroth commented 9 years ago

just bitted us too.

ballPointPenguin commented 9 years ago

+1 for this.

jehrhardt commented 9 years ago

:+1:

For the moment downgrading to broccoli-sass@0.2.4 works.

mixonic commented 9 years ago

Is 2.0.1 backward compatible? If so this should definitely go in. homebrew just stated shipping node 0.12 as default.

workmanw commented 9 years ago

:+1: We're in the same boat.

joliss commented 9 years ago

@hipertracker Thanks for this PR! The diff was a little bit too long to review effectively ;-) - it's basically a rewrite - but I updated the dependency myself in 6e600fe and released it in v0.4.0.