search

joliss / broccoli-sass

Sass compiler for Broccoli, using libsass
MIT License
44 stars 97 forks source link

Fix for changes related to merge-trees #8

Closed twokul closed 10 years ago

twokul commented 10 years ago

Related to this issue.

nathanhammond commented 10 years ago

:+1: Can we pretty please get this one landed?

HeroicEric commented 10 years ago

I'm wondering whether the intended input is supposed to be sourceTrees or inputTrees. It's shown being used both ways in the README. However, the variable name in the code (https://github.com/joliss/broccoli-sass/blob/master/index.js#L14) is sourceTrees.

Is this the intended behavior?

nathanhammond commented 10 years ago

Almost all of the other Broccoli plugins are using inputTrees as the variable name, broccoli-sass is the odd one out–which I think explains this PR, a tiny oversight. :)

HeroicEric commented 10 years ago

@nathanhammond great. I mostly just wanted to get the discussion/action moving on this again.

joliss commented 10 years ago

Thanks Alex! Hm, broccoli-sass actually expects an array, not a merged tree, so this change would break it.

joliss commented 10 years ago

I've commented at https://github.com/stefanpenner/ember-cli/issues/265#issuecomment-39994483. Hope that helps! :-)