search

jolleekin / modern_charts

BSD 2-Clause "Simplified" License
66 stars 12 forks source link

Chart.draw()'s options parameter is not optional #17

Closed zmeggyesi closed 5 years ago

zmeggyesi commented 5 years ago

Although the function signature lists the options map as an optional parameter, if it is not passed, no defaults are substituted and mergeMap errors out.

Invocation: chart.draw(chartData);

Stacktrace:

EXCEPTION: NullError: invalid member on null: 'forEach'
STACKTRACE: 
package:modern_charts/src/utils.dart 156:6                               mergeMap
package:modern_charts/src/base.dart 873:25                               draw
jolleekin commented 5 years ago

Fixed in https://github.com/jolleekin/modern_charts/commit/021512122df11d898cb50918717c262f97f76a27