search

jolocom / jolocom-lib

Library for interacting with the identity solution provided by Jolocom.
MIT License
24 stars 18 forks source link

Remove web3 dependency #280

Closed palinka closed 5 years ago

palinka commented 5 years ago

Description

When adding our lib to a project, web3 in the version we use produces warnings which is not nice for our users:

warning jolocom-lib > jolocom-registry-contract > web3 > web3-bzz > swarm-js > fs-promise@2.0.3: Use mz or fs-extra^3.0 with Promise Support
warning jolocom-lib > jolocom-registry-contract > web3 > web3-bzz > swarm-js > tar.gz@1.0.7: ⚠️  WARNING ⚠️ tar.gz module has been deprecated and your application is vulnerable. Please use tar module instead: https://npmjs.com/tar

As far as I know we just use it in our tests, see #272.

Lets remove it completely?

Check

palinka commented 5 years ago

We use this version of web3: https://github.com/jolocom/jolocom-lib/pull/279/commits/f0268529108ab41b3e39238d79fab1d798a7f27f

palinka commented 5 years ago

This branch could be used: https://github.com/jolocom/jolocom-lib/pull/279

chunningham commented 5 years ago

web3 has since been removed as a direct dependancy, closing