Don't mutate input objects

jolocom / jolocom-lib

Library for interacting with the identity solution provided by Jolocom.

MIT License

24 stars 18 forks source link

Don't mutate input objects #315

Open mnzaki opened 5 years ago

mnzaki commented 5 years ago

Description

The library sometimes mutates input objects, for example in identityWallet.create.signedCredential, the claim object gets an id field added to it (which contains the DID)

Part of #355

BREAKING CHANGE: some code might depend on the behavior??

TODO

[ ] look for other instances
[ ] PR

mnzaki commented 5 years ago

NOTE: this is an old report and needs to be reconfirmed