jolocom / jolocom-lib

Library for interacting with the identity solution provided by Jolocom.
MIT License
24 stars 18 forks source link

Downgrade bip39 dependency #342

Closed VolkerSchiewe closed 5 years ago

VolkerSchiewe commented 5 years ago

Because react native uses an old version of the JS Core it does not support some modern JS features. An example for that is String.prototype.normalize() which is used in bip39.js starting from version 3.0.0. In earlier versions of this library they use the package unorm which provides that feature also for earlier versions of node.

mnzaki commented 5 years ago

why not add a shim for String.prototype.normalize instead of downgrading though?

VolkerSchiewe commented 5 years ago

I tried to polyfill this yesterday but it did not worked out, but now I found a way which works fine :+1: