Open mnzaki opened 5 years ago
Instead of having to do things like:
import { Identity } from 'jolocom-lib/js/identity/identity'
import { SoftwareKeyProvider } from 'jolocom-lib/js/vaultedKeyProvider/softwareProvider'
One option is exporting everything from index so users can do:
import { Identity, SoftwareKeyProvider } from 'jolocom-lib'
Another option is to consider the JolocomLib
export our "public API" and just add whatever is missing to it. But types/interfaces will need to be exported, can't be added to the JolocomLib
object
Description
Library consumers need to import certain interfaces and classes, they should not be using the direct paths or else we might break things if we make internal changes.
A definite "public" interface should be declared, specifying which interfaces are expected to be used publicly. Whether everything should be exported from
ts/index.ts
is still an open question. Perhaps some categorization?Here are the imports from inside jolocom/smartwallet-app except for tests:
And here are imports from tests:
Part of #355
TODO