jolpica / jolpica-f1

Apache License 2.0
41 stars 1 forks source link

Inconsistencies when filtering by finishing status #15

Closed theOehrly closed 5 months ago

theOehrly commented 5 months ago

When filtering by finishing status (/status/<n>), the results are implausible in some cases.

Milestone is TBD depending on what turns out to be the cause here.

Affected endpoints

At least 'drivers', 'constructors', 'circuits', 'status', potentially more

Affected status values (2023)

The following four status filters produce incorrect/implausible results. The problems are different for each filter value.

Example

Ideas

I haven't managed to really make sense of this so far. It seems like there are inconsistencies here in Ergast and in the new API. But those inconsistencies are not the same.

My best guess at the moment is that something during the data import goes wrong when trying to correct some of these inconsistencies.

Notably, all four problematic status endpoints include the digit "3" which might point towards a problematic search/replace or regex. But there are other status values in the 2023 season that include the digit "3" but don't cause any issues.

jolpica commented 5 months ago

I think I've figured this one out. The /status endpoint was only counting race results, but the filter for other endpoints was counting sprint races.