search

joltup / react-native-threads

Create new JS processes for CPU intensive work
MIT License
755 stars 141 forks source link

Feature/add v8 support #111

Open hannojg opened 4 years ago

hannojg commented 4 years ago

This PR makes this library compatible with V8 runtime for react native (https://github.com/Kudo/react-native-v8).

I am not sure whether there is a better implementation for doing the Hermes availability detection than I did. For me, it works using V8!

I made this based on #110, so this probably needs to be merged first.

nwpray commented 3 years ago

Thanks for the submission @hannojg we are looking at your changes right now. Sorry for the delay.

hannojg commented 3 years ago

There was somewhat an issue with that code when using it not with v8, it couldn’t find the imports of I remember correctly. (We don’t use threads anymore so i can‘t test)

nwpray commented 3 years ago

Sounds good, we will test it both ways

kamranpirwani commented 3 years ago

Can confirm this works on Android -- using this in our fork