search

joltup / rn-fetch-blob

A project committed to making file access and data transfer easier, efficient for React Native developers.
MIT License
2.81k stars 770 forks source link

convert to new react native config format #408

Closed Traviskn closed 4 years ago

Traviskn commented 4 years ago

according to the react-native cli docs: hooks are considered anti-pattern, please avoid them I'm not sure that we should continue to support the prelink script that auto-adds the android manifest permissions. it would likely be best to just document the required permissions and require that you add them yourself

IntelliJAbhishek commented 4 years ago

@Traviskn Just add required permission in docs. No need to autolink permission. A proper docs would be enough.

oleksandr-dziuban commented 4 years ago

@IntelliJAbhishek Hello, can we merge this PR?

IntelliJAbhishek commented 4 years ago

@oleksandr-dziuban maintainers of this repo can merge this PR.

filmhomage commented 4 years ago

+1 Same here. Please merge this PR.

congnguyen91 commented 4 years ago

+1 please check this PR & merge :) thanks

caigehui commented 4 years ago

+1 please check this PR & merge :) thanks

caigehui commented 4 years ago

+1 please check this PR & merge :) thanks

BaderSerhan commented 4 years ago

Waiting for this merge ! :)

romreed commented 4 years ago

When this merge will be in master?

mvanroon commented 4 years ago

When this merge will be in master?

When someone merges the PR?

oleksandr-dziuban commented 4 years ago

@Traviskn Hello, is it possible to merge this PR? Or this library is not maintained anymore?

oleksandr-dziuban commented 4 years ago

I don't think we need the react-native.config.js script at all. The script installs permissions, but these are already mentioned in the readme

We need it anyway to mograte to latest react-native standards, so could you please merge it?

Traviskn commented 4 years ago

merging for now, planning on a follow up PR to update the README and remove the hook entirely