search

joltup / rn-fetch-blob

A project committed to making file access and data transfer easier, efficient for React Native developers.
MIT License
2.81k stars 772 forks source link

[build issue] implementation in IOS7Polyfill.h file #585

Open yzs132 opened 4 years ago

yzs132 commented 4 years ago

Hi!

In, https://github.com/joltup/rn-fetch-blob/blob/master/ios/IOS7Polyfill.h

The @implementation is put into the header file, so it ends up being copied into every source file that it is imported in. It shows build warnings/errors as below:

stderr: ld: warning: instance method 'RNFBContainsString:' in category from...(RNFetchBlobReqBuilder.m.o) conflicts with same method from another category ld: warning: instance method 'RNFBContainsString:' in category from ...(RNFetchBlobFS.m.o) conflicts with same method from another category

It is also a patch for a method that has existed since iOS 8 since we don't really need this any more.

Thanks!

partiellkorrekt commented 3 years ago

I have created a pull-request that should do the job